Skip to content

vectorstore: Fix in exists operator. Was working as null #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

vectorstore: Fix in exists operator. Was working as null #51

merged 1 commit into from
May 18, 2024

Conversation

MartinGotelli
Copy link
Contributor

@MartinGotelli MartinGotelli commented May 17, 2024 •
edited
Loading

So... yeah I f***ed up. But this is the fix.

The $exists was working as the $null, but the rename implies also changing how the bool value is interpreted:

$exists: True (there is a tag, I don't care the value)
$exists: False (no tag in there)

ref: #40

@eyurtsev eyurtsev merged commit 9912f54 into langchain-ai:main May 18, 2024
6 checks passed
@eyurtsev
Copy link
Collaborator

Thanks @MartinGotelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinGotelli @eyurtsev